Repository navigation
Fix !summarize for links in angle brackets or with query strings - #43
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
!summarizefailed on links wrapped in<…>, which is how Discord users and feed posts suppress link previews. The link pattern kept the closing>, so Kagi was asked to summarize a URL that doesn't exist and answered with a 500. The bot only logged the status and said nothing in the channel.The link pattern now stops at
>. The link is also encoded as a single query value:&,=and+were left unencoded before, so a link likeyoutube.com/watch?v=…&t=…reached Kagi cut off at the&.When an API call fails, the HTTP helpers now log the start of the response body, where APIs explain the error. The body stays out of the error's description because
!xcodeand!sepost that description to the channel.!summarizenow replies in the channel when it fails, with the details only in the log.Markdown masked links (
[text](https://…)) still keep a trailing). Stripping it would break URLs that legitimately end in), such as Wikipedia's.🤖 Generated with Claude Code
https://claude.ai/code/session_01QpqSb1b4xUhYTBckar28PZ